feat(overlay): emit position change event #1832
Conversation
googlebot
added
the
cla: yes
kara
force-pushed
the
overlay-origin
branch
2 times, most recently
from
db7f108
to
e85f664
Compare
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
googlebot
added
cla: no
kara
added
cla: yes
|
CLAs look good, thanks! |
kara
changed the title
| @@ -36,6 +38,12 @@ export class ConnectedPositionStrategy implements PositionStrategy { | |||
| /** The origin element against which the overlay will be positioned. */ | |||
| private _origin: HTMLElement; | |||
|
|
|||
| private _onPositionChange: Subject<ConnectedOverlayPositionChange> = new Subject(); | |||
|
|
|||
| /** Emits an event when a fallback position is used. */ | |||
There was a problem hiding this comment.
It would be more accurate to say that it emits whenever the connection point changes (based on what will fit on the screen).
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
r: @jelbourn